AL-1038: Fixes #1697, terminus whoami no longer exits with 1 #1926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 1 when unauthenticated
|
The tests need updating here. Is |
|
@greg-1-anderson No, not being logged in is not an erroneous state. |
|
OK we'll allow for non-erroneous, non-status-0 exits in the upstream then. |
TeslaDethray
suggested changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The annotated command library really wants to print '[error]' when the exit code is non-zero, for consistency. If that is okay, then the fix is trivial, as shown.
If the desire is to maintain a '[notice]' and still have the exit code be non-zero, then a modification to the annotated command library would be necessary. We could simply omit the '[error]' output when the message is empty. Consistency is probably better, though; it might be odd to have the command appear to finish successfully, but still set a non-zero exit code.